Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add connector_skipped_records metric #87

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: add connector_skipped_records metric #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions java-toolkit/lib/src/main/java/io/hstream/io/standalone/StandaloneSinkTaskContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public class StandaloneSinkTaskContext implements SinkTaskContext {
Counter readBytesCounter;
Counter deliveredRecordsCounter;
Counter deliveredBytesCounter;
Counter skippedRecordsCounter;
Histogram readLatency;
Histogram deliveredLatency;
String stream;
Expand Down Expand Up @@ -222,6 +223,10 @@ void handleWithRetry(Consumer<SinkRecordBatch> handler, SinkRecordBatch batch) {
log.warn("delivery record failed:{}, tried:{}", e.getMessage(), count);
if (!retryStrategy.showRetry(batch.getShardId(), e)) {
if (sinkSkipStrategy.trySkipBatch(batch, e.getMessage())) {
if (enablePrometheusReport) {
skippedRecordsCounter.labelValues(stream, String.valueOf(batch.getShardId()))
.inc(batch.getSinkRecords().size());
}
return;
} else {
fail();
Expand Down Expand Up @@ -300,6 +305,12 @@ void setupPrometheusReport() {
.labelNames("streamName", "shardId")
.register();

skippedRecordsCounter = Counter.builder()
.name("connector_skipped_records")
.help("skipped records")
.labelNames("streamName", "shardId")
.register();

// latency
readLatency = Histogram.builder()
.name("connector_read_latency")
Expand Down
Loading