Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: displayed disconnected shop config on the shopListing tab as 'Disconnected' (#155) #232

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amansinghbais
Copy link
Contributor

Related Issues

Closes #155

Short Description and Why It's Useful

  • Removed the checks for 'SHOP_NO_ACCESS' from the getShopifyShopConfig so as to fetch the disconnected shop configs.
  • Displayed disconnected shop configs in the shop listing status tab in the product summary page.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2023-09-20 14-50-24
Screenshot from 2023-09-20 14-40-58

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle disabled shop configs
1 participant