Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: support to exclude order and inventory filters when configure a route(#248) #262

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented Sep 30, 2024

Related Issues

#248

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

After:

image

image

Contribution and Currently Important Rules Acceptance

@ymaheshwari1 ymaheshwari1 changed the title #248 Implemented: support to exclude order and inventory filters when configure a route(#248) Oct 15, 2024
@ymaheshwari1 ymaheshwari1 marked this pull request as ready for review October 15, 2024 08:56
@ymaheshwari1
Copy link
Contributor Author

For order filters, we have added all the current filters in the excluded list, and we have not handled the case to not allow the user to select those options that are already selected in its corresponding exclude/include filter. Here we have considered that user configuring the rules will be aware of the conflicts that may occur when selecting same filter as exclude and include both with similar values.

For inventory filter, we have added exclude filter option only for the facilityGroup filter, as all the other filters does not need to have the exclude check. For the facility group filter, we have handled the case to not allow the select the same value in the exclude and include filter.

@ymaheshwari1 ymaheshwari1 merged commit fe00f4b into hotwax:main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant