Implemented: NetSuite Integration Management UI(#37) #38
Conversation
src/views/NetSuite.vue
Outdated
| </script> | ||
|
|
||
| <style scoped> | ||
| main { |
There was a problem hiding this comment.
why use main element here? we can simply just add ion padding to ion content right? @R-Sourabh
src/views/NetSuite.vue
Outdated
| <ion-icon slot="end" :icon="chevronForwardOutline"/> | ||
| </ion-item> | ||
| </ion-card> | ||
| <ion-card> |
There was a problem hiding this comment.
we shouldn't use ion-card here. Like in Figma, directly use ion item with outline and border radius. We should make this a global style in our app themes. We use this item pattern in the fulfillment app and I expect to use it again. @R-Sourabh
There was a problem hiding this comment.
I misunderstood that sir, I'll change it.
src/views/NetSuite.vue
Outdated
|
|
||
| <div class="ion-margin-top"> | ||
| <ion-text>Configuration</ion-text> | ||
| <section> |
There was a problem hiding this comment.
I think this UI patter in itself will be, or has been frequently reused. Lets make a DXP component where you can pass in:
list of item labels and p tags in labels. You can also pass in the action icon that will be displayed on each of the items' end slots.
something like:
title: section-name
itemEndIcon: icon-name
items: [{primary label, secondary label}]
There was a problem hiding this comment.
Sure, I'll look into this.
| } | ||
|
|
||
| .item-box::part(native) { | ||
| border-radius: 8px; |
There was a problem hiding this comment.
why not just use the ion item custom property for border radius?
https://ionicframework.com/docs/api/item#css-custom-properties-1
--border-radius
| grid-template-columns: repeat(auto-fill, minmax(300px, 1fr)); | ||
| gap: 10px; |
There was a problem hiding this comment.
use spacer variables here instead of hard coded value. I know you are recreating the default margin of ion card, but if you're replacing, it is recommended to use premade spacer.
Related Issues
#37
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance