Sanitize column names to follow defined standards #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spwoodcock
approved these changes
Nov 15, 2024
| "label::Swahili(sw)": [name], | ||
| "label::French(fr)": [name], | ||
| "label::Spanish(es)": [name], | ||
| "label::english(en)": [name], |
There was a problem hiding this comment.
Very nice addition!
@Sujanadh
Just checking that forms definitely work with the lowercase label? Did you manage to test anywhere? 🙏
(I don't see why not, as it should match the (en) key, but need to be sure!)
There was a problem hiding this comment.
Yes it does, i tested it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This feature includes functionality to standardize all column names to contain lowercase letters without space within.
standardize_xlsform_sheetsto remove spaces and lowercase all column headers, fixes formatting for columns with '::' (e.g., multilingual labels) in both the 'survey' and 'choices' sheets of an XLSForm.Issue:
When a user uploads a custom form with some column names like
label::English (en)with a space betweenEnglishand(en), it will create duplicate columns with existing mandatory form fieldslabel::English(en)having multiple same labels for language columns. Due to this there was an issue of not showing questions while loading in odk collect.