-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Server side HoverTool for rasterized/datashaded plots with selector #6422
Draft
hoxbro
wants to merge
47
commits into
main
Choose a base branch
from
inspect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+326
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
added
the
type: enhancement
Minor feature or improvement to an existing feature
label
Oct 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6422 +/- ##
==========================================
- Coverage 88.50% 88.48% -0.03%
==========================================
Files 323 323
Lines 68631 68806 +175
==========================================
+ Hits 60741 60880 +139
- Misses 7890 7926 +36 ☔ View full report in Codecov by Sentry. |
hoxbro
changed the title
enh: Update hovertool server side for rasterized plots
enh: Make HoverTool update server side for rasterized/datashaded plots
Oct 28, 2024
hoxbro
changed the title
enh: Make HoverTool update server side for rasterized/datashaded plots
feat: Make HoverTool update server side for rasterized/datashaded plots
Nov 5, 2024
hoxbro
changed the title
feat: Make HoverTool update server side for rasterized/datashaded plots
feat: Server side HoverTool for rasterized/datashaded plots
Nov 5, 2024
hoxbro
changed the title
feat: Server side HoverTool for rasterized/datashaded plots
feat: Server side HoverTool for rasterized/datashaded plots with selector
Nov 5, 2024
Ordering matters!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we sent all hover data to the front end, which could lead to significant overhead on larger plots. With this PR, the data is pushed server-side to the hover tool with a custom data model.
Currently working on
datashade(agg=by, sel=min)
anddatashade(agg=by, sel=min)
.Example script