Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish with selector #189

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Publish with selector #189

wants to merge 14 commits into from

Conversation

hoc081098
Copy link
Owner

Status

READY/IN DEVELOPMENT/HOLD

Breaking Changes

YES | NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Requirements

  • Dump api
  • Update README
  • Update CHANGELOG
  • Add tests
  • Add docs

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: Patch coverage is 0% with 222 lines in your changes are missing coverage. Please review.

Project coverage is 68.43%. Comparing base (aa451b5) to head (70f7633).
Report is 3 commits behind head on master.

❗ Current head 70f7633 differs from pull request most recent head 55d6e50. Consider uploading reports for the commit 55d6e50 to get more accurate results

Files Patch % Lines
...otlin/com/hoc081098/flowext/publishWithSelector.kt 0.00% 196 Missing and 4 partials ⚠️
...otlin/com/hoc081098/flowext/internal/SimpleLazy.kt 0.00% 11 Missing ⚠️
...om/hoc081098/flowext/internal/SimpleSuspendLazy.kt 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #189       +/-   ##
===========================================
- Coverage   87.91%   68.43%   -19.49%     
===========================================
  Files          37       37               
  Lines         811     1020      +209     
  Branches      110      154       +44     
===========================================
- Hits          713      698       -15     
- Misses         53      273      +220     
- Partials       45       49        +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant