Skip to content

Commit

Permalink
encoder: esp32 no need to pull up
Browse files Browse the repository at this point in the history
There is default pull down in the ESP32Encoder lib.

Signed-off-by: Thomas Chou <[email protected]>
  • Loading branch information
hippo5329 committed Feb 25, 2024
1 parent 45453f6 commit f1894f6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion firmware/lib/encoder/encoder.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class Encoder
pin2 = temp_pin;
}
counts_per_rev_ = counts_per_rev;
ESP32Encoder::useInternalWeakPullResistors = UP;
encoder_.attachHalfQuad(pin1, pin2);
}
float getRPM() {
Expand Down

0 comments on commit f1894f6

Please sign in to comment.