Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build.zig): examples can be run independently & sysaudio exmples renamed as tests #1296

Merged

Conversation

RonaldZielaznicki
Copy link
Contributor

@RonaldZielaznicki RonaldZielaznicki commented Oct 30, 2024

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Changes

  • Separated example compile/install from b.getInstallStep()
    • Allows for building individual examples without others
  • Moved core tests out core folder
    • But, renamed them with a core- prefix
  • Renamed SysAudio examples as tests
  • Fixed deprecated call to std.mem.split within SysAudio's sine test case

Pics

Before

image

After

image

build.zig Outdated Show resolved Hide resolved
build.zig Outdated Show resolved Hide resolved
Copy link
Member

@slimsag slimsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks like a great improvement

Also, very minor nit but in general I try to keep PR and commit titles in this form:

<code area>: what the change does

e.g.

build: make examples run independently; rename sysaudio examples to tests

build: windows: fix the build

core: improve window title API

core: macOS: fix window creation

etc. etc.

Primary reason I don't like the conventional commits is it reminds me of too many low quality JS projects 😝

@RonaldZielaznicki
Copy link
Contributor Author

@slimsag

Hah, I got into the habit because a previous employer had us using them. Despite being a python stack.

I can switch it up.

@RonaldZielaznicki
Copy link
Contributor Author

Should be good to merge soon as the CI clears it.

@slimsag slimsag merged commit 910e8f6 into hexops:main Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants