Call XInitThreads first; XCloseDisplay cleanup #1291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1290
Context
yppy provided some excellent advise on discord:
And after I mentioned an error code on exit, they also advised:
The discussion after lead to the realization that
platform.deinit
is called before the GPU backend is released. This caused a race condition where the GPU backend might interact with the window before it is released.Changes
libx11.XInitThreads
is now called first when initializing X11.errorHandler
in favor of the default handler's more verbose description.platform.deinit
is now called after the GPU backend has been released.Some additional detail
To show why I removed the custom X11 error handler.
Custom Error Message
Default Error Message