Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metadata): trim responses before parsing #547

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix(metadata): trim responses before parsing #547

merged 1 commit into from
Nov 5, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Nov 5, 2024

Fixes #540

@jooola jooola requested a review from a team as a code owner November 5, 2024 11:31
@jooola jooola requested a review from apricote November 5, 2024 11:31
@jooola jooola force-pushed the metadata-trim-responses-before-parsing branch from 2d372ed to 5bbf73d Compare November 5, 2024 11:32
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.95%. Comparing base (1d97017) to head (5bbf73d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   68.08%   67.95%   -0.13%     
==========================================
  Files          47       47              
  Lines        4900     4902       +2     
==========================================
- Hits         3336     3331       -5     
- Misses       1158     1163       +5     
- Partials      406      408       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 283363f into main Nov 5, 2024
5 checks passed
@jooola jooola deleted the metadata-trim-responses-before-parsing branch November 5, 2024 12:33
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Merged
jooola pushed a commit that referenced this pull request Nov 5, 2024
@github-actions
chore(main): release 2.16.0 (#546)
677d80f 
🤖 I have created a release *beep* *boop*
---


##
[2.16.0](v2.15.0...v2.16.0)
(2024-11-05)


### Features

* use custom IDOrName type for schemas
([#545](#545))
([1d97017](1d97017))


### Bug Fixes

* **metadata:** trim responses before parsing
([#547](#547))
([283363f](283363f)),
closes [#540](#540)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Nov 5, 2024
@jooola
fix(deps): update module github.com/hetznercloud/hcloud-go/v2 to v2.1…
9efa068 
…6.0 (hetznercloud/fleeting-plugin-hetzner!158)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.15.0` -> `v2.16.0` |

---

### Release Notes

<details>
<summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary>

### [`v2.16.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.16.0)

[Compare Source](hetznercloud/hcloud-go@v2.15.0...v2.16.0)

##### Features

-   use custom IDOrName type for schemas ([#&#8203;545](hetznercloud/hcloud-go#545)) ([1d97017](hetznercloud/hcloud-go@1d97017))

##### Bug Fixes

-   **metadata:** trim responses before parsing ([#&#8203;547](hetznercloud/hcloud-go#547)) ([283363f](hetznercloud/hcloud-go@283363f)), closes [#&#8203;540](hetznercloud/hcloud-go#540)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(metadata): trim responses before parsing
2 participants
@jooola @apricote