feat(exp): add retry package #479
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 71.56% 71.65% +0.08%
==========================================
Files 45 46 +1
Lines 3904 3923 +19
==========================================
+ Hits 2794 2811 +17
- Misses 696 698 +2
Partials 414 414 ☔ View full report in Codecov by Sentry. |
apricote
reviewed
Jul 10, 2024
| Policy func(err error) bool | ||
| } | ||
|
|
||
| func Retry[T any](opts Opts, request func() (T, *hcloud.Response, error)) (T, *hcloud.Response, error) { |
There was a problem hiding this comment.
Could you add examples for these to showcase how one can use them?
There was a problem hiding this comment.
Haha, I would love to, but:
- Terraform is still using v1, so we don't have the experimental package https://github.com/search?q=repo%3Ahetznercloud%2Fterraform-provider-hcloud+ErrorCodeLocked&type=code
- HCCM is blocked by the prometheus go library version conflict https://github.com/search?q=repo%3Ahetznercloud%2Fhcloud-cloud-controller-manager+ErrorCodeLocked&type=code
- The rest of the integrations don't seem to have a need for it yet.
Let's wait until we find a use case that we can implement and test against.
jooola
force-pushed
the
retryutils
branch
2 times, most recently
from
ac6a961
to
2fc0a6d
Compare
|
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few retry utilities that may be used in certain context to retry failed requests based on a policy.
Related to #470