Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplicate functionality #314

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

apricote
Copy link
Member

@apricote apricote commented Sep 5, 2023

The isConflict() method duplicates the functionality of the IsError() method.

The `isConflict()` method duplicates the functionality of the
`IsError()` method.
@apricote apricote added the backport release-1.x Open PR against release-1.x with these changes after the PR is merged. label Sep 5, 2023
@apricote apricote self-assigned this Sep 5, 2023
@apricote apricote requested a review from a team as a code owner September 5, 2023 12:29
@apricote apricote merged commit 8043160 into main Sep 5, 2023
4 checks passed
@apricote apricote deleted the refactor-is-error-method branch September 5, 2023 12:44
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
The `isConflict()` method duplicates the functionality of the
`IsError()` method.

(cherry picked from commit 8043160)
apricote added a commit that referenced this pull request Sep 5, 2023
The `isConflict()` method duplicates the functionality of the
`IsError()` method.

(cherry picked from commit 8043160)

Co-authored-by: Julian Tölle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.x Open PR against release-1.x with these changes after the PR is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants