fix: include running action progress in WatchOverallProgress #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the running action progress in the actions progress calculation. The function now consider a failed action as completed, and is included in the progress.
jooola
force-pushed
the
fix-progress-in-WatchOverallProgress
branch
from
57fd0d0
to
e2506fe
Compare
jooola
changed the title
apricote
approved these changes
Aug 15, 2023
apricote
added
the
backport release-1.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-304-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 867aa632521ad3acfb04beb52b6307330740fc68
# Push it to GitHub
git push --set-upstream origin backport-304-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.xThen, create a pull request where the |
apricote
pushed a commit
that referenced
this pull request
Aug 17, 2023
Include the running action progress in the actions progress calculation. The function now considers a failed action as completed, and is included in the progress. Not counting the failed action as completed might send some weird progress values e.g. [0%, 75%, (failed action occurs here) 50%], while if we count them, we should have [0%, 75%, 100%]. Related to hetznercloud/cli#528 (cherry picked from commit 867aa63)
apricote
added a commit
that referenced
this pull request
Aug 17, 2023
Include the running action progress in the actions progress calculation. The function now considers a failed action as completed, and is included in the progress. Not counting the failed action as completed might send some weird progress values e.g. [0%, 75%, (failed action occurs here) 50%], while if we count them, we should have [0%, 75%, 100%]. Related to hetznercloud/cli#528 (cherry picked from commit 867aa63) Co-authored-by: Jonas L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the running action progress in the actions progress calculation.
The function now considers a failed action as completed, and is included in the progress. Not counting the failed action as completed might send some weird progress values e.g. [0%, 75%, (failed action occurs here) 50%], while if we count them, we should have [0%, 75%, 100%].
Related to hetznercloud/cli#528