feat: test with Go 1.21 (#319)

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go-version: ["1.19", "1.20"]
+        go-version: ["1.19", "1.20", "1.21"]
     steps:
     - name: Set up Go ${{ matrix.go-version }}
       uses: actions/setup-go@v4

.github/workflows/golangci-lint.yml

@@ -17,7 +17,7 @@ jobs:
         uses: golangci/golangci-lint-action@v3
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version
-          version: v1.53.2
+          version: v1.54.2
 
           # Optional: working directory, useful for monorepos
           # working-directory: somedir

.gitlab-ci.yml

@@ -20,7 +20,7 @@ test:golangci-lint:
 
 test:tests:
   stage: test
-  image: golang:1.20
+  image: golang:1.21
   script:
     - go test -v -race ./...
   except:

.golangci.yaml

@@ -60,3 +60,6 @@ issues:
       linters:
         - gosec
         - errcheck
+    - path: hcloud/error.go
+      # False-positive in error codes
+      text: "G101: Potential hardcoded credentials" # gosec

go.mod

@@ -1,5 +1,9 @@
 module github.com/hetznercloud/hcloud-go/v2
 
+// This is being kept at a lower value on purpose as raising this would require
+// all dependends to update to the new version.
+// As long as we do not depend on any newer language feature this can be kept at the current value.
+// It should never be higher than the lowest currently supported version of Go.
 go 1.19
 
 require (

hcloud/schema.go

@@ -970,7 +970,7 @@ func loadBalancerCreateOptsToSchema(opts LoadBalancerCreateOpts) schema.LoadBala
 					TLS:      service.HealthCheck.HTTP.TLS,
 				}
 				if service.HealthCheck.HTTP.StatusCodes != nil {
-					schemaHealthCheckHTTP.StatusCodes = &service.HealthCheck.HTTP.StatusCodes
+					schemaHealthCheckHTTP.StatusCodes = &service.HealthCheck.HTTP.StatusCodes //nolint:gosec // does not result in bug
 				}
 				schemaHealthCheck.HTTP = schemaHealthCheckHTTP
 			}

hcloud/schema_test.go

@@ -2403,6 +2403,32 @@ func TestLoadBalancerCreateOptsToSchema(t *testing.T) {
 							},
 						},
 					},
+					{
+						Protocol:        LoadBalancerServiceProtocolHTTP,
+						DestinationPort: Ptr(443),
+						Proxyprotocol:   Ptr(true),
+						HTTP: &LoadBalancerCreateOptsServiceHTTP{
+							CookieName:     Ptr("keks"),
+							CookieLifetime: Ptr(5 * time.Minute),
+							RedirectHTTP:   Ptr(true),
+							StickySessions: Ptr(true),
+							Certificates:   []*Certificate{{ID: 1}, {ID: 2}},
+						},
+						HealthCheck: &LoadBalancerCreateOptsServiceHealthCheck{
+							Protocol: LoadBalancerServiceProtocolHTTP,
+							Port:     Ptr(443),
+							Interval: Ptr(5 * time.Second),
+							Timeout:  Ptr(1 * time.Second),
+							Retries:  Ptr(3),
+							HTTP: &LoadBalancerCreateOptsServiceHealthCheckHTTP{
+								Domain:      Ptr("example.com"),
+								Path:        Ptr("/health"),
+								Response:    Ptr("ok"),
+								StatusCodes: []string{"4??", "5??"},
+								TLS:         Ptr(true),
+							},
+						},
+					},
 				},
 				Targets: []LoadBalancerCreateOptsTarget{
 					{
@@ -2457,6 +2483,32 @@ func TestLoadBalancerCreateOptsToSchema(t *testing.T) {
 							},
 						},
 					},
+					{
+						Protocol:        string(LoadBalancerServiceProtocolHTTP),
+						DestinationPort: Ptr(443),
+						Proxyprotocol:   Ptr(true),
+						HTTP: &schema.LoadBalancerCreateRequestServiceHTTP{
+							CookieName:     Ptr("keks"),
+							CookieLifetime: Ptr(5 * 60),
+							RedirectHTTP:   Ptr(true),
+							StickySessions: Ptr(true),
+							Certificates:   Ptr([]int64{1, 2}),
+						},
+						HealthCheck: &schema.LoadBalancerCreateRequestServiceHealthCheck{
+							Protocol: string(LoadBalancerServiceProtocolHTTP),
+							Port:     Ptr(443),
+							Interval: Ptr(5),
+							Timeout:  Ptr(1),
+							Retries:  Ptr(3),
+							HTTP: &schema.LoadBalancerCreateRequestServiceHealthCheckHTTP{
+								Domain:      Ptr("example.com"),
+								Path:        Ptr("/health"),
+								Response:    Ptr("ok"),
+								StatusCodes: Ptr([]string{"4??", "5??"}),
+								TLS:         Ptr(true),
+							},
+						},
+					},
 				},
 				Targets: []schema.LoadBalancerCreateRequestTarget{
 					{