Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Grafana dashboard and ServiceMonitors #378

Merged
merged 2 commits into from
Feb 21, 2023
Merged

feat: add Grafana dashboard and ServiceMonitors #378

merged 2 commits into from
Feb 21, 2023

Conversation

apricote
Copy link
Member

@apricote apricote commented Feb 14, 2023

Add a default dashboard to visualize the exposed metrics as well as ServiceMonitors and a guide on how to set everything up.

Related to #346

@apricote apricote added the enhancement New feature or request label Feb 14, 2023
@apricote apricote self-assigned this Feb 14, 2023
@apricote apricote merged commit f5ed56b into main Feb 21, 2023
@apricote apricote deleted the monitoring branch February 21, 2023 09:39
@splattner
Copy link

this should also be added to the kustomization.yaml

@apricote apricote mentioned this pull request Feb 23, 2023
4 tasks
@apricote
Copy link
Member Author

Hey @splattner, thanks for the suggestion :) I was thinking about that, but wanted to keep the existing kustomization.yaml backwards compatible. The problems with that approach are:

  • If we add the ServiceMonitors to the main kustomization.yaml, it will require prometheus-operator to be installed beforehand (or at least its CRDs) and fail for clusters that dont have the operator
  • There is no standard way to deploy Grafana dashboards, we could make a ConfigMap out of it though

We did add a new kustomization.yaml that you can use to install the ServiceMonitors: deploy/kubernetes/service-monitor/kustomization.yaml

I also plan on adding this to an upcoming Helm Chart, see #369

lukasmetzner pushed a commit that referenced this pull request Oct 10, 2024
* feat: add dashboard and ServiceMonitors

* docs: allow users to research topics in depth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants