-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataHub Connector #350
Open
adamczyk-HERE
wants to merge
13
commits into
v2
Choose a base branch
from
http_connector_storage
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DataHub Connector #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
Files
|
hirenkp2000
requested changes
Sep 27, 2024
...http/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceReadExecute.java
Outdated
Show resolved
Hide resolved
...http/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceReadExecute.java
Outdated
Show resolved
Hide resolved
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
from
October 2, 2024 09:36
8c71fb2
to
c25cc01
Compare
Code Coverage
Files
|
adamczyk-HERE
changed the title
Draft: CASL-533 GetFeaturesByIdEvent POC
CASL-533 GetFeaturesByIdEvent POC
Oct 2, 2024
Code Coverage
Files
|
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
from
October 2, 2024 09:41
c25cc01
to
91cea2b
Compare
Code Coverage
Files
|
hirenkp2000
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
hirenkp2000
approved these changes
Oct 3, 2024
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
from
October 8, 2024 13:26
81f2b2a
to
02f6176
Compare
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
from
October 10, 2024 12:56
02f6176
to
bf6e61b
Compare
Code Coverage
Files
|
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
from
October 10, 2024 15:25
bf6e61b
to
03b886b
Compare
Code Coverage
Files
|
Code Coverage
Files
|
Code Coverage
Files
|
Code Coverage
Files
|
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
from
October 21, 2024 11:16
5e1f3ae
to
cdb38cb
Compare
hirenkp2000
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good so far. Pls look into minor comments and also address pipeline failure.
here-naksha-storage-http/src/main/java/com/here/naksha/storage/http/PrepareResult.java
Outdated
Show resolved
Hide resolved
...http/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceReadExecute.java
Outdated
Show resolved
Hide resolved
...http/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceReadExecute.java
Outdated
Show resolved
Hide resolved
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
3 times, most recently
from
October 30, 2024 16:42
e01e40f
to
029d13a
Compare
Code Coverage
Files
|
Signed-off-by: Adamczyk, Tomasz <[email protected]> Signed-off-by: adamczyk-HERE <[email protected]>
Signed-off-by: adamczyk-HERE <[email protected]>
Signed-off-by: adamczyk-HERE <[email protected]>
Signed-off-by: adamczyk-HERE <[email protected]>
Signed-off-by: adamczyk-HERE <[email protected]>
Signed-off-by: adamczyk-HERE <[email protected]>
Signed-off-by: adamczyk-HERE <[email protected]>
Signed-off-by: adamczyk-HERE <[email protected]>
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
from
October 30, 2024 17:07
029d13a
to
05c7436
Compare
Code Coverage
Files
|
Signed-off-by: adamczyk-HERE <[email protected]>
Code Coverage
Files
|
Signed-off-by: adamczyk-HERE <[email protected]>
Code Coverage
Files
|
hirenkp2000
requested changes
Nov 14, 2024
...-naksha-storage-http/src/main/java/com/here/naksha/storage/http/HttpStorageWriteSession.java
Outdated
Show resolved
Hide resolved
...-naksha-storage-http/src/main/java/com/here/naksha/storage/http/HttpStorageWriteSession.java
Outdated
Show resolved
Hide resolved
...ttp/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceWriteExecute.java
Show resolved
Hide resolved
...ttp/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceWriteExecute.java
Outdated
Show resolved
Hide resolved
...ttp/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceWriteExecute.java
Outdated
Show resolved
Hide resolved
...ttp/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceWriteExecute.java
Outdated
Show resolved
Hide resolved
...ttp/src/main/java/com/here/naksha/storage/http/connector/ConnectorInterfaceWriteExecute.java
Outdated
Show resolved
Hide resolved
Signed-off-by: adamczyk-HERE <[email protected]>
Code Coverage
Files
|
Signed-off-by: adamczyk-HERE <[email protected]>
Signed-off-by: adamczyk-HERE <[email protected]>
adamczyk-HERE
force-pushed
the
http_connector_storage
branch
from
November 18, 2024 09:15
cb65f35
to
620f892
Compare
Code Coverage
Files
|
Code Coverage
Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.