This repository has been archived by the owner on May 21, 2021. It is now read-only.
Changes for > 7.6.2 #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helhum
suggested changes
Sep 15, 2016
| public function setOriginalResource(\TYPO3\CMS\Core\Resource\ResourceInterface $originalResource) | ||
| { | ||
| $this->originalResource = $originalResource; | ||
| $this->originalFileIdentifier = (int)$originalResource->getOriginalFile()->getUid(); |
There was a problem hiding this comment.
ResourceInterface does not have the getOriginalFile() method.
Can you add a instance of FileReference check to avoid a potential fatal error?
There was a problem hiding this comment.
You are right. I have pushed an new commit with the FileReference check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forge.typo3.org/issues/71567
Solves:
PHP Warning: Declaration of VENDOR\EXT\Domain\Model\FileReference::setOriginalResource(TYPO3\CMS\Core\Resource\FileReference $originalResource) should be compatible with TYPO3\CMS\Extbase\Domain\Model\FileReference::setOriginalResource(TYPO3\CMS\Core\Resource\ResourceInterface $originalResource) in /html/typo3/typo3conf/ext/EXT_NAME/Classes/Domain/Model/FileReference.php line 47