Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Job: Add sort function for job durations #2566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Nov 13, 2024

This change adds a sort function for job duration times. Previously, sorting by duration would show the list of jobs out of order, but this should no longer be the case.

Fixes: #2564

Testing

  • Open Headlamp with multiple jobs of varying durations
  • Sort by duration and ensure that the jobs are properly sorted

image

@skoeva skoeva added bug Something isn't working frontend Issues related to the frontend labels Nov 13, 2024
@skoeva skoeva self-assigned this Nov 13, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 13, 2024
This change adds a sort function for job duration times. Previously,
sorting by duration would show the list of jobs out of order, but this
should no longer be the case.

Fixes: #2564

Signed-off-by: Evangelos Skopelitis <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Issues related to the frontend lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

Sorting by duration incorrectly sorts seconds vs minutes
2 participants