Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: add support for gateway-api #2504

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

farodin91
Copy link
Contributor

No description provided.

@farodin91
Copy link
Contributor Author

@joaquimrocha I'm not sure, if it's better to move this into a plugin or make gateway more present. This only adds stable resources.

What do you think? Views can be improved.

@illume
Copy link
Collaborator

illume commented Nov 4, 2024

Hi @farodin91

@joaquimrocha (and rest of team) has been busy the last days with very many release related things, and also some holidays.

To plugin or not? The gateway API is part of the Kubernetes project, so in that sense maybe it should be in Headlamp... but yeah... it's not a core Kubernetes thing. The other question to ask, is how commonly it's used? To me it's not entirely clear where it should be. Maybe you could provide more context?

@farodin91
Copy link
Contributor Author

@illume i think Kubernetes is pushing gateway API for the last month quiet hard. I would say. It's now stable.

@farodin91 farodin91 force-pushed the add-support-for-gateway-api branch 3 times, most recently from 1e18382 to 05c4bee Compare November 7, 2024 22:14
@illume
Copy link
Collaborator

illume commented Nov 12, 2024

@joaquimrocha Yeah, I agree it should go in headlamp rather than a plugin. This week I was learning about gateway API. Basically it’s the successor to Ingress. My understanding is gateway API is cleaning and standardizing things, and addressing missing spots (L4-L7 vs only http L7). As of the 1.2 release in October, quite a lot of the API is stable. There's several implementations of the http/TLS routers, less of the GRPC routers, and even fewer of the mesh routers (which is the main part left with experimental APIs AFAIK).

@farodin91 farodin91 force-pushed the add-support-for-gateway-api branch 2 times, most recently from 8000e87 to e232b95 Compare November 16, 2024 13:55
@farodin91 farodin91 marked this pull request as ready for review November 16, 2024 14:07
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 16, 2024
@farodin91
Copy link
Contributor Author

@illume Would you like to review this PR? I think the ui can be improved or extend over time. Their is also a magic route called gateway, so i had to change route to k8sgateway. Do you have an idea why their is a magic route?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants