Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting by duration incorrectly sorts seconds vs minutes #2564

Open
rukas opened this issue Nov 13, 2024 · 1 comment · May be fixed by #2566
Open

Sorting by duration incorrectly sorts seconds vs minutes #2564

rukas opened this issue Nov 13, 2024 · 1 comment · May be fixed by #2566
Assignees
@skoeva
Labels
bug Something isn't working

Comments

@rukas
Copy link

rukas commented Nov 13, 2024

Describe the bug

When sorting jobs by duration the UI incorrectly sorts a larger number of seconds to be greater than a smaller number of minutes.

Ex. 59s is larger than 19m

To Reproduce

Steps to reproduce the bug:

  1. Go to Jobs
  2. Run jobs that run various durations, including some that run for seconds and some that run for minutes
  3. Sort by Duration (either ascending or descending)
  4. See that it is incorrectly sorting the duration

Environment (please provide info about your environment):

  • Installation type: Windows
  • Headlamp Version: 0.26.0
  • Other: n/a

Are you able to fix this issue?

No.

Do you want to help fix this issue? Please see our contribution docs. For any non-trivial contributions, we advise you to join our our slack channel to discuss the implementation with Headlamp's core developers.

Additional Context

image
@rukas rukas added the bug Something isn't working label Nov 13, 2024
@skoeva skoeva self-assigned this Nov 13, 2024
@skoeva
Copy link
Contributor

skoeva commented Nov 13, 2024

Thanks for submitting this, will take a look

skoeva added a commit that referenced this issue Nov 13, 2024
@skoeva
frontend: Job: Add sort function for job durations
11b332c 
This change adds a sort function for job duration times. Previously,
sorting by duration would show the list of jobs out of order, but this
should no longer be the case.

Fixes: #2564

Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva linked a pull request Nov 13, 2024 that will close this issue
Open
2 tasks
skoeva added a commit that referenced this issue Nov 13, 2024
@skoeva
frontend: Job: Add sort function for job durations
7da4469 
This change adds a sort function for job duration times. Previously,
sorting by duration would show the list of jobs out of order, but this
should no longer be the case.

Fixes: #2564

Signed-off-by: Evangelos Skopelitis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoeva skoeva

Labels
bug Something isn't working
Projects
Release Plan / Roadmap
Status: Queued
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: Job: Add sort function for job durations headlamp-k8s/headlamp
2 participants
@rukas @skoeva