-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage to 90% #1198
Coverage to 90% #1198
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1198 +/- ##
==========================================
+ Coverage 89.12% 90.92% +1.80%
==========================================
Files 45 43 -2
Lines 9947 9525 -422
Branches 2827 2722 -105
==========================================
- Hits 8865 8661 -204
+ Misses 762 571 -191
+ Partials 320 293 -27 ☔ View full report in Codecov by Sentry. |
Review Notes: I did a few rounds of searches to make sure anything region reference related is removed. There is one method I left a note on. HDMF_Zarr needs to be updated when this is merged. |
This is great. Could you also remove |
And |
Motivation
Getting coverage to at least 90% and going through deprecations for HDMF 4.0
Checklist
CHANGELOG.md
with your changes?