Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage to 90% #1198

Merged
merged 18 commits into from
Nov 14, 2024
Merged

Coverage to 90% #1198

merged 18 commits into from
Nov 14, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Oct 24, 2024

Motivation

Getting coverage to at least 90% and going through deprecations for HDMF 4.0

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.92%. Comparing base (8c3eecb) to head (43618c3).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/hdmf/backends/hdf5/h5tools.py 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1198      +/-   ##
==========================================
+ Coverage   89.12%   90.92%   +1.80%     
==========================================
  Files          45       43       -2     
  Lines        9947     9525     -422     
  Branches     2827     2722     -105     
==========================================
- Hits         8865     8661     -204     
+ Misses        762      571     -191     
+ Partials      320      293      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 requested a review from rly November 14, 2024 02:06
@mavaylon1
Copy link
Contributor Author

Review Notes: I did a few rounds of searches to make sure anything region reference related is removed. There is one method I left a note on. HDMF_Zarr needs to be updated when this is merged.

@rly rly marked this pull request as ready for review November 14, 2024 02:12
src/hdmf/query.py Outdated Show resolved Hide resolved
src/hdmf/query.py Outdated Show resolved Hide resolved
@rly
Copy link
Contributor

rly commented Nov 14, 2024

This is great. Could you also remove fmt_docval_args from hdmf/utils.py?

@rly
Copy link
Contributor

rly commented Nov 14, 2024

And call_docval_func and the blocks of commented functions in hdmf/utils.py

@mavaylon1 mavaylon1 requested a review from rly November 14, 2024 03:38
@mavaylon1 mavaylon1 merged commit c71537a into dev Nov 14, 2024
28 of 29 checks passed
@mavaylon1 mavaylon1 deleted the cov branch November 14, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants