Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload consul configuration #229

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jorgemarey
Copy link

Attemps to fix #53.

This PR allows to reload the configuration to reload the consul values like token, certs ...
This is useful when deploying the ESM with short lived consul credentials (nomad - vault integration)

Changes:

  • Intercep sighup signal to reload
  • Create a lock around the client using the getClient() method so each time we use it there was a change in configuration it'll use the new client.
  • Change how leader routine works. As the lock struct doesn't allow to change the client. We need to stop the lock and create it again.

@jorgemarey jorgemarey requested a review from a team as a code owner August 10, 2023 09:39
@jorgemarey jorgemarey requested review from roncodingenthusiast and removed request for a team August 10, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Rotating ACL Tokens
1 participant