-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Active Custom Scoreboard Patterns #2927
Open
j10a1n15
wants to merge
6
commits into
hannibal002:beta
Choose a base branch
from
j10a1n15:backend/scoreboard-patterns
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+182
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
github-actions
bot
added
the
Backend
A backend pull request that will be merged soon
label
Nov 14, 2024
Signed-off-by: J10a1n15 <[email protected]>
One or more Detekt Failures were detected:
|
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
github-actions
bot
added
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
Nov 15, 2024
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
github-actions
bot
removed
the
Merge Conflicts
There are open merge conflicts with the beta branch.
label
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This Pull Request improves the Custom Scoreboard to only do important regex checks. Each Element now contains their respective patterns and using the showIslands() we now filter out not for the current island important patterns. This should reduce the amount of regex checks by like 60% I assume, so yay more fps (maybe)
Todo:
/shdebug custom scoreboard
Changelog Technical Details