Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: New Year Cake Tracker #2237

Merged
merged 66 commits into from
Nov 15, 2024

Conversation

DavidArthurCole
Copy link
Contributor

@DavidArthurCole DavidArthurCole commented Jul 19, 2024

What

Requested here.
Adds a New Year Cake Tracker that will store owned/missing cakes of users that are stored in Cake Bags, Ender Chests, and backpacks. Will highlight cakes not owned in the Auction House.

There is one known "problem," being that if NEU's Storage Overlay is enabled, tracking of Cakes in EC/BP no longer work. If anyone wants to venture a guess as to a fix for this, feel free.

Images

Brief video showing functionality:

https://youtu.be/QNjJu0zyE6s

image

Changelog New Features

  • Added New Year Cake Tracker. - Daveed.
    • Highlights unowned cakes in AH.
    • Displays a list of missing cake years.

@hannibal002 hannibal002 added this to the Version 0.27 milestone Jul 19, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jul 30, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jul 30, 2024
Copy link

Conflicts have been resolved! 🎉

@DavidArthurCole DavidArthurCole force-pushed the CakeTracker branch 2 times, most recently from da3c0b5 to 2694845 Compare August 21, 2024 17:30
@hannibal002 hannibal002 modified the milestones: Version 0.27, Version 0.28 Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 7, 2024
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

Conflicts have been resolved! 🎉

Copy link

github-actions bot commented Sep 8, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Sep 8, 2024
Copy link
Contributor

@ItsEmpa ItsEmpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i lied those were not my last requested changes

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@github-actions github-actions bot added Detekt Has detekt problem and removed Detekt Has detekt problem labels Nov 12, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The display shows up in an chest on private island, even when there is no cake inside.

@hannibal002 hannibal002 enabled auto-merge (squash) November 15, 2024 21:12
@hannibal002 hannibal002 merged commit 352afc4 into hannibal002:beta Nov 15, 2024
6 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Nov 15, 2024
@DavidArthurCole DavidArthurCole deleted the CakeTracker branch November 15, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants