Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit vscale_range() fn attribute in correct syntax #8457

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Emit vscale_range() fn attribute in correct syntax #8457

merged 1 commit into from
Nov 6, 2024

Conversation

steven-johnson
Copy link
Contributor

Per comments on llvm/llvm-project#114900, we emit the vscale_range attribute in slightly malformed fashion; this emits in the preferred fashion.

@steven-johnson
Emit vscale_range() fn attribute in correct syntax
fe3ef3f 
Per comments on llvm/llvm-project#114900, we emit the vscale_range attribute in slightly malformed fashion; this emits in the preferred fashion.
@steven-johnson steven-johnson mentioned this pull request Nov 5, 2024
Closed
@steven-johnson
Copy link
Contributor Author

Ping, this is blocking some google3 issues

@steven-johnson steven-johnson merged commit f981571 into main Nov 6, 2024
17 of 19 checks passed
@steven-johnson steven-johnson deleted the srj/vscale-ir branch November 6, 2024 18:28
steven-johnson added a commit that referenced this pull request Nov 6, 2024
@steven-johnson
Fix #8455 (in combination with #8457) (#8456)
a1723e7 
* Partial fix for #8455

In slice_vector(), only check for type equality after vectors have been normalized to fixed (i.e., it's ok for some original input to be vscale)

* Update CodeGen_LLVM.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvookin zvookin zvookin approved these changes

@alexreinking alexreinking alexreinking approved these changes

@abadams abadams Awaiting requested review from abadams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steven-johnson @alexreinking @zvookin