Get more consistent distributions in parallel scenarios test #8451
+41
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
approved these changes
Oct 30, 2024
mcourteaux
reviewed
Nov 8, 2024
| const int memory_limit = m ? max_memory : 128; | ||
|
|
||
| auto now = std::chrono::high_resolution_clock::now; | ||
| auto to_ns = [](auto delta) { return 1e9 * std::chrono::duration<float>(delta).count(); }; |
There was a problem hiding this comment.
Nitpick: 1e9 is a double, so the lambda returns a double. Either 1e9f, or the results vector should become double.
|
ready to land? |
|
Looks like there was a merge conflict to fix. Apart from that, assuming everything goes green, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is not denoising the individual runtimes. The point of the test is to measure a distribution of runtimes for a variety of scenarios. This PR takes more samples for each distribution, and spreads the samples out over time to dodge transitory OS stuff by interleaving different test scenarios.
I also tweaked some of the scenarios to be more useful, and reported actual deciles so that the median is actually there.