refact: refactored simplify logic and adding comments to unit value lib

halcwb · Sep 2, 2023 · a1e7457 · a1e7457
1 parent 3c78e94
commit a1e7457
Show file tree

Hide file tree

Showing 4 changed files with 323 additions and 107 deletions.
diff --git a/src/Informedica.GenSolver.Lib/Variable.fs b/src/Informedica.GenSolver.Lib/Variable.fs
@@ -277,7 +277,7 @@ module Variable =
                     if vu |> ValueUnit.isEmpty |> not then
                         vu |> create true
                     else
-                        vu |> ValueUnit.setZeroNonNegative |> create false
+                        vu |> ValueUnit.setZeroOrPositive |> create false
 
                 let fExcl vu =
                     let vu =
@@ -286,7 +286,7 @@ module Variable =
                     if vu |> ValueUnit.isEmpty |> not then
                         vu |> create false
                     else
-                        vu |> ValueUnit.setZeroNonNegative |> create false
+                        vu |> ValueUnit.setZeroOrPositive |> create false
 
                 apply fIncl fExcl
 

diff --git a/src/Informedica.GenUnits.Lib/Scripts/Api.fsx b/src/Informedica.GenUnits.Lib/Scripts/Api.fsx
@@ -10,8 +10,11 @@ open Informedica.GenUnits.Lib
 open Informedica.Utils.Lib.BCL
 
 open Swensen.Unquote
+open Tests
 
 
+Tests.testNumDenom()
+
 // Test Array.removeBigRationalMultiples
 let testRemoveBigRationalMultiples () =
     let test (act : BigRational[]) (exp : BigRational[]) =