GH-15772 upgrade to gradle 8.4 #16141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valenad1
force-pushed
the
valenad-GH-15772-upgrade-to-gradle-8-4
branch
from
dd1830b
to
c81bf08
Compare
valenad1
force-pushed
the
valenad-GH-15772-upgrade-to-gradle-8-4
branch
4 times, most recently
from
4f8d2a9
to
bc79e03
Compare
mn-mikke
reviewed
Apr 24, 2024
h2o-hadoop-2/assemblyjar.gradle
Outdated
| @@ -78,6 +73,17 @@ dependencies { | |||
| api(project(":h2o-parquet-parser")) { | |||
| transitive = false | |||
| } | |||
|
|
|||
| constraints { | |||
| api("org.apache.hadoop:hadoop-client:$hadoopMavenArtifactVersion") | |||
There was a problem hiding this comment.
Have you checked that the hadoop artifacts are the same after this change?
There was a problem hiding this comment.
that's a very good point - those were not the same, that option didn't force
I pushed a new version - there are still some strange differences, but stuff like guava is forced firmly at 20.0
overall that kind of comparison I think we need to do also for other stuff
valenad1
force-pushed
the
valenad-GH-15772-upgrade-to-gradle-8-4
branch
from
9b8e433
to
6d9f394
Compare
valenad1
force-pushed
the
valenad-GH-15772-upgrade-to-gradle-8-4
branch
from
6d9f394
to
4dafffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15772
I am running it on nightly: http://jenkins:8080/view/H2O-3/job/h2o-3-nightly-pipeline/job/valenad-GH-15772-upgrade-to-gradle-8-4/4/
and it seem good, in terms of the current jenkins conditions. I would like to merge to master rather than directly to rel-*