-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use corepack instead of committing a version of yarn #9610
Conversation
Size Change: 0 B Total Size: 699 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should corepack enable
come after the node setup? Otherwise we’re relying on the version of node shipped in the action to work
EDIT: no, because it’s a known bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of ~150kLoC is very welcome!
dc4ebab
to
8f6c3fe
Compare
933c601
to
0219ec9
Compare
0219ec9
to
39ae441
Compare
Of course I found my answer here. And a mere 19 hours after you merged 😆 |
what was the question...? |
I found the link to this PR while searching for how to use yarn 3 in our Github actions, via actions/setup-node#480 |
What does this change?
sets the repo up to use corepack, rather than a version of yarn being committed the codebase.
Why?
enables seamless adoption of any alternative to yarn 1, and is now the preferred way of using yarn and supported by pnpm.
Screenshots
with an incorrect version of yarn installed, and corepack not enabled:
with no yarn installed, and corepack not enabled:
with corepack enabled (with and without another version of yarn installed):