Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logic to allow plotting "all" for thresholds and levels #2

Open
wants to merge 3 commits into
base: feature/generate_metviewer_xmls
Choose a base branch
from

Conversation

mkavulich
Copy link

Hi Gerard, sorry this is so late. Here is a description of the new logic:

  • Users can now specify "all" as an argument for either level or threshold (or both).
  • generate_metviewer_xml now returns a list of XML file paths rather than a single file path. If used in the original way, this simply means it's a single-item list, and the
  • Returning a list of xmls allows the function to be called recursively, by "extending" the output list if there are already items in it
  • If "all" is specified for level or threshold, it loops over the dictionaries set in the get_static_info function: valid_levels_by_fcst_var and valid_threshs_by_fcst_var respectively. It then recursively calls the generate_metviewer_xml function for each of these levels and/or thresholds
  • Finally, at the top level we simply loop over each item in that list of xmls, calling run_mv_batch for each xml generated.

Let me know if you have any questions or there's anything else I can help with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant