Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval statistics. #77

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Eval statistics. #77

merged 1 commit into from
Feb 12, 2020

Conversation

andorp
Copy link
Member

@andorp andorp commented Feb 10, 2020

This is a preliminary for the counting immutable beans implementation.

Motivation: The CIB runtime reuses heap locations after instrumentation of the code. I am going to implement such an evaluator but before that I would like to measure the heap access patterns for the Idris compiled programs. Thus I need this piece of functionality first.

Copy link
Member

@csabahruska csabahruska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Anabra
Copy link
Member

Anabra commented Feb 12, 2020

I have done something similar in the past. Maybe have a look at this? I personally prefer another monadic layer to tuple return.

Copy link
Member

@Anabra Anabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, however IMO we should refactor the implementation after merging the changes of #32.

@andorp
Copy link
Member Author

andorp commented Feb 12, 2020

@Anabra I agree. My plan here is to wait for the #32 and import the abstract interpretation mechanism from mini-grin which can implement the definitional interpreter and can be decorated easily, like including the statistics. I should have mentioned this raising this PR.

@andorp andorp merged commit 219727c into master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants