fix(PM): close with timeout

gravity-ui · Oct 9, 2024 · 4aa404f · 4aa404f
1 parent 26ca36f
commit 4aa404f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/promo-manager/core/controller.ts b/src/promo-manager/core/controller.ts
@@ -203,8 +203,6 @@ export class Controller {
         this.stateActions.removeFromQueue(slug);
 
         this.updateProgressInfo(slug);
-
-        this.triggerNextPromo();
     };
 
     cancelPromo = (slug: Nullable<PromoSlug>, closeActiveTimeout = 0) => {

diff --git a/src/promo-manager/tests/controller.test.ts b/src/promo-manager/tests/controller.test.ts
@@ -260,6 +260,17 @@ describe('trigger subscribe', () => {
         expect(callback).toHaveBeenCalledTimes(1);
     });
 
+    it('finish with timeout -> 1 update', async () => {
+        await controller.requestStart('boardPoll');
+
+        const callback = jest.fn();
+        controller.subscribe(callback);
+
+        await controller.finishPromo('boardPoll', 500);
+
+        expect(callback).toHaveBeenCalledTimes(1);
+    });
+
     it('cancel -> 1 update', async () => {
         await controller.requestStart('boardPoll');
 
@@ -271,6 +282,17 @@ describe('trigger subscribe', () => {
         expect(callback).toHaveBeenCalledTimes(1);
     });
 
+    it('cancel with timeout -> 1 update', async () => {
+        await controller.requestStart('boardPoll');
+
+        const callback = jest.fn();
+        controller.subscribe(callback);
+
+        await controller.cancelPromo('boardPoll', 500);
+
+        expect(callback).toHaveBeenCalledTimes(1);
+    });
+
     it('skipPromo -> 1 update', async () => {
         await controller.requestStart('boardPoll');