-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove deprecated Function.prototype.caller reference #3806
Conversation
🦋 Changeset detectedLatest commit: 91fde2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thanks @simmerer ! I am currently in the process of migrating most of this logic to a lower service level, and will be removing this usage of noting that this will cause bugs when users accidentally double tap the execute button, or execute multiple queries quickly in serial, as the usage of |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3806 +/- ##
=======================================
Coverage 65.32% 65.32%
=======================================
Files 122 122
Lines 7003 7003
Branches 2260 2260
=======================================
Hits 4575 4575
Misses 2411 2411
Partials 17 17
|
a134923
to
91fde2b
Compare
I'm going to call this good to go for now, as the full resolution will be introduced in 4.x soon! thank you! |
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Deprecated_caller_or_arguments_usage
While it's helpful during development to have as much information as possible about which component doesn't have the necessary context, it's very not helpful to have the error message itself throw a blocking error due to this deprecated usage 😅
In a future PR, it might be nice to rename the
caller
argument found throughout GraphiQL packages to something likecallerFn
for clarity, making it clear at a glance that it's a custom arg and not an attempt to accessFunction.prototype.caller
.