-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] product_print_category: use key instead of xml_id #149
base: 12.0
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## 12.0 #149 +/- ##
==========================================
+ Coverage 78.62% 78.84% +0.21%
==========================================
Files 141 142 +1
Lines 2255 2278 +23
Branches 362 364 +2
==========================================
+ Hits 1773 1796 +23
Misses 430 430
Partials 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@legalsylvain If we can get in touch about that during OCA Days. :) |
@legalsylvain I've tested this modification: ✔️ local, with demo data. This is the PDF generated by the demo data: Pricetags.pdf |
@legalsylvain Can it be merge ? :) |
@legalsylvain up on that. :) |
@legalsylvain Sorry I found that it was part of the migration on 16.0 here: OCA/product-attribute#1176 So it's ok to me to leave the PR open and not merged. It's in production on our server. :) |
👍 |
Use the
key
instead of thexml_id
to find qweb template for the pricetag. This let user create their own template via the Odoo interface, because such template does not havexml_id
.Step to reproduce:
product.print.category
and refer to the previously created qweb template.Intended behaviour:
Pricetag can be generated using the new qweb template
Occurring:
Error when generating template saying that template
''
is not found.Issue:
The problem comes from the fact that qweb template created in the Odoo interface has no
xml_id
as they do not comes from a file in a module.Fix:
Using the field
key
instead of the fieldxml_id
fix this.coopiteasy task