Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement using k6foundry #111

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Reimplement using k6foundry #111

merged 8 commits into from
Nov 15, 2024

Conversation

pablochacin
Copy link
Collaborator

@pablochacin pablochacin commented Nov 12, 2024 •
edited
Loading

Replace build logic with k6foundry library. Also, refactors the build argument parsing logic to facilitate testing.

This change required upgrading to golang 1.22 (required by k6foundry).

Breaking change in xk6.Build library: the Build method no longer completes missing attributes using environment variables. The function FromOSEnv can be used to create Builder from the environment variable and then override or complete its attributes. See README.md for an example

@pablochacin
Use k6foundry for building
583a60d 
Signed-off-by: Pablo Chacin <[email protected]>
@pablochacin
refactor build options parsing
aa23803 
Signed-off-by: Pablo Chacin <[email protected]>
@pablochacin
update README
cd53a87 
Signed-off-by: Pablo Chacin <[email protected]>
@pablochacin pablochacin requested a review from a team as a code owner November 12, 2024 10:39
@pablochacin pablochacin requested review from szkiba and removed request for a team November 12, 2024 10:39
@pablochacin pablochacin marked this pull request as draft November 12, 2024 10:40
@pablochacin pablochacin force-pushed the reimplement-using-k6foundry branch 2 times, most recently from f771d18 to 502bd14 Compare November 12, 2024 12:34
@pablochacin
reintroduce license headers
37bd11f 
Signed-off-by: Pablo Chacin <[email protected]>
@pablochacin
update go version
afab1c3 
Signed-off-by: Pablo Chacin <[email protected]>
@pablochacin
update linter
d96ee7c 
Signed-off-by: Pablo Chacin <[email protected]>
@pablochacin pablochacin marked this pull request as ready for review November 12, 2024 13:16
szkiba
szkiba approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@szkiba szkiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablochacin pablochacin merged commit 686292c into master Nov 15, 2024
5 checks passed
pablochacin added a commit that referenced this pull request Nov 15, 2024
@pablochacin
Revert "Reimplement using k6foundry (#111)"
0880709 
This reverts commit 686292c.
@pablochacin pablochacin mentioned this pull request Nov 15, 2024
Merged
pablochacin added a commit that referenced this pull request Nov 15, 2024
@pablochacin
Revert "Reimplement using k6foundry (#111)" (#113)
4c76f08 
This reverts commit 686292c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szkiba szkiba szkiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablochacin @szkiba