MQE changes for Prometheus 3 upgrade #9948
Open
+7,237
−4,114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <[email protected]>
…w left-open behaviour in Prometheus 3
…left-open interval behaviour
charleskorn
requested review from
stevesg,
grafanabot and
a team
as code owners
4 tasks
aknuds1
force-pushed
the
arve/upgrade-mimir-prometheus
branch
from
78797ed
to
d920e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR makes all changes required to bring MQE into line with Prometheus 3's behaviour.
This PR is blocked by two bugfixes currently pending review from the Prometheus team:
boolmodifier and native histograms prometheus/prometheus#15413If we want to unblock the upgrade, we could cherry-pick these fixes into mimir-prometheus.
This PR depends on prometheus/prometheus#15245 being pulled into mimir-prometheus.
This PR is also blocked pending confirmation of the expected behaviour of subqueries with the change to left-open intervals for range queries: prometheus/prometheus#15412 (this is why
TestSubqueriesis currently failing)This PR builds upon #9844.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.