Don't hold labels from store-gateways in two forms, and don't convert them multiple times #9914
+46
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
changed the title
charleskorn
force-pushed
the
charleskorn/dont-hold-labels-twice
branch
from
9fda371
to
5efdf1c
Compare
jhesketh
approved these changes
Nov 18, 2024
charleskorn
added a commit
that referenced
this pull request
Nov 18, 2024
… them multiple times (#9914) (#9930) * Don't hold labels from store-gateways in two forms * Don't retain labels longer than needed * Don't convert mimirpb.LabelAdaptors to labels.Labels multiple times * Add changelog entry (cherry picked from commit d2367de) Co-authored-by: Charles Korn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Previously, queriers would hold two copies of the labels for each series from a store-gateway: once as a
[]mimirpb.LabelAdapter(in thestorepb.StreamingSeriesheld byblockStreamingQuerierSeriesSet) and again as alabels.Labels(passed tonewBlockStreamingQuerierSeries). This means that queries that select many series use twice as much memory as they need to for labels, which can be problematic for queries that select many series with many labels.This PR modifies the behaviour of queriers to only hold the labels as a
labels.Labelsinstance.It also fixes the issue where
[]mimirpb.LabelAdapterinstances are converted tolabels.Labelsmultiple times when streaming chunks: once when applying the series limiter, and again for use when iterating through series. Multiple conversions are still used when not streaming chunks, but given this is not the default behaviour and fixing this would be a more complex change, I've chosen to leave it as-is.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.