tests(distributor): improve checks during ha_tracker sync cache on startup #9905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, to verify the sync
NickAnge
changed the title
|
The dskit library has an existing "mock" |
dimitarvdimitrov
dismissed
their stale review
I didn't see Nick's comment before approving. His suggestion makes sense to me 👍
2 tasks
NickAnge
force-pushed
the
nickange/ha_tracker/improve-testing-sync-cache-onstartup
branch
from
c3e856e
to
7febb63
Compare
NickAnge
requested review from
stevesg,
grafanabot and
a team
as code owners
dimitarvdimitrov
approved these changes
Nov 15, 2024
4 tasks
dimitarvdimitrov
deleted the
nickange/ha_tracker/improve-testing-sync-cache-onstartup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates the
TestHATrackerCacheSyncOnStartto use theMockCountingClientthat was introduced in dskit (Ref). This will allow us to better test if the sync happened during the ha_tracker creationFollow up of this: #9826
Which issue(s) this PR fixes or relates to
Improve testing scenarios
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.