Fix flaky TestIngester_Push_CircuitBreaker_DeadlineExceeded test #9900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test would sometimes fail:
The test assumes that it will execute one successful request, and then 4 failing requests. However, sometimes the first request would take longer to execute than the configured
100ms
timeout, and the circuit breaker would close after the second overall request, rather than after the third.The trivial fix is to increase the push timeout to a larger value, so that the initial request has time to complete successfully, even if the test runner is slow. This PR bumps it to
1s
.With this change I was able to run this test 1000x without failure locally: