Get rid of -querier.prefer-streaming-chunks-from-ingesters #7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
reviewed
Mar 18, 2024
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/deprecated-feature-1
branch
2 times, most recently
from
1459119
to
740629a
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/deprecated-feature-1
branch
from
740629a
to
9805602
Compare
charleskorn
reviewed
Mar 18, 2024
duricanikolic
changed the title
Signed-off-by: Yuri Nikolic <[email protected]>
charleskorn
approved these changes
Mar 19, 2024
grafanabot
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Get rid of querier.prefer-streaming-chunks-from-ingesters Signed-off-by: Yuri Nikolic <[email protected]> * Fixing a failing test Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> * Fixing failing tests Signed-off-by: Yuri Nikolic <[email protected]> * Make lint happy Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> --------- Signed-off-by: Yuri Nikolic <[email protected]> (cherry picked from commit 8ed42e1)
grafanabot
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Get rid of querier.prefer-streaming-chunks-from-ingesters Signed-off-by: Yuri Nikolic <[email protected]> * Fixing a failing test Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> * Fixing failing tests Signed-off-by: Yuri Nikolic <[email protected]> * Make lint happy Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> --------- Signed-off-by: Yuri Nikolic <[email protected]> (cherry picked from commit 8ed42e1)
duricanikolic
added a commit
that referenced
this pull request
Mar 19, 2024
…7661) * Get rid of querier.prefer-streaming-chunks-from-ingesters Signed-off-by: Yuri Nikolic <[email protected]> * Fixing a failing test Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> * Fixing failing tests Signed-off-by: Yuri Nikolic <[email protected]> * Make lint happy Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> --------- Signed-off-by: Yuri Nikolic <[email protected]> (cherry picked from commit 8ed42e1) Co-authored-by: Đurica Yuri Nikolić <[email protected]>
duricanikolic
added a commit
that referenced
this pull request
Mar 19, 2024
…7662) * Get rid of querier.prefer-streaming-chunks-from-ingesters Signed-off-by: Yuri Nikolic <[email protected]> * Fixing a failing test Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> * Fixing failing tests Signed-off-by: Yuri Nikolic <[email protected]> * Make lint happy Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> --------- Signed-off-by: Yuri Nikolic <[email protected]> (cherry picked from commit 8ed42e1) Co-authored-by: Đurica Yuri Nikolić <[email protected]>
duricanikolic
added a commit
that referenced
this pull request
Mar 20, 2024
* Move -querier.minimize-ingester-requests from experimental to advanced (#7649) Signed-off-by: Yuri Nikolic <[email protected]> * Get rid of -querier.prefer-streaming-chunks-from-ingesters (#7639) (#7661) * Get rid of querier.prefer-streaming-chunks-from-ingesters Signed-off-by: Yuri Nikolic <[email protected]> * Fixing a failing test Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> * Fixing failing tests Signed-off-by: Yuri Nikolic <[email protected]> * Make lint happy Signed-off-by: Yuri Nikolic <[email protected]> * Fixing review findings Signed-off-by: Yuri Nikolic <[email protected]> --------- Signed-off-by: Yuri Nikolic <[email protected]> (cherry picked from commit 8ed42e1) Co-authored-by: Đurica Yuri Nikolić <[email protected]> * [query-frontend] Close response body in request handler (#7654) (#7663) * [query-frontend] Close response body in request handler (#7654) * [query-frontend] close response body in request handler (cherry picked from commit eaef377) * changelog * Update VERSIOn for release 2.12.0-rc.1 (#7671) Signed-off-by: Yuri Nikolic <[email protected]> --------- Signed-off-by: Yuri Nikolic <[email protected]> Co-authored-by: Grot (@grafanabot) <[email protected]> Co-authored-by: Felix Beuke <[email protected]>
|
This PR is missing CHANGELOG entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR is needed for the release of Mimir 2.12.
Experimental CLI flag
-querier.prefer-streaming-chunks-from-ingestershas been enabled by default and marked for deletion in Mimir 2.12 in #6174.This PR gets rid of this CLI flags.
As a consequence, distributor's configuration option
distributor.Config. PreferStreamingChunksFromIngesters, that is currently always set to true, should also be removed.Which issue(s) this PR fixes or relates to
Part of #7542
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.