Skip to content

Commit

Permalink
Remove offset-tracking code that doesn't work correctly.
Browse files Browse the repository at this point in the history
  • Loading branch information
seizethedave committed Nov 13, 2024
1 parent 9393468 commit 98cb58c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/blockbuilder/scheduler/scheduler.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,9 @@ func (s *BlockBuilderScheduler) updateJob(key jobKey, workerID string, complete
return fmt.Errorf("complete job: %w", err)
}
}
s.committed.AddOffset(s.cfg.Kafka.Topic, j.partition, j.endOffset, -1)
s.dirty = true

// TODO: Push forward the local notion of the committed offset.

s.logger.Log("msg", "completed job", "key", key, "worker", workerID)
} else {
// It's an in-progress job whose lease we need to renew.
Expand Down

0 comments on commit 98cb58c

Please sign in to comment.