Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix round function not honoring delayed name removal flag #748

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Nov 13, 2024

Cherry-pick PR Fix round function not honoring delayed name removal flag, on request from @charleskorn. This harmonizes with v2.55.1, which Mimir is now based on, so that the round function drops the metric name.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aknuds1
❌ yeya24
You have signed the CLA already but the status is still pending? Let us recheck it.

Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1 aknuds1 added the bug Something isn't working label Nov 15, 2024
@aknuds1 aknuds1 merged commit f1021fc into main Nov 15, 2024
8 of 9 checks passed
@aknuds1 aknuds1 deleted the arve/round-drop-name branch November 15, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants