Fix issue where PostingsForMatchersCache can cache a context cancellation error
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Korn <[email protected]>
…che. Signed-off-by: Charles Korn <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
approved these changes
Oct 20, 2023
aknuds1
deleted the
charleskorn/postingsformatcherscache-context-cancellation
branch
2 tasks
aknuds1
added a commit
that referenced
this pull request
Oct 20, 2023
…ache-context-cancellation Fix issue where `PostingsForMatchersCache` can cache a context cancellation error
charleskorn
commented
Oct 23, 2023
| promise = oldPromise.(*postingsForMatcherPromise) | ||
| return promise.result | ||
| // promise was not stored, we return a previously stored promise, that's possibly being fulfilled in another goroutine | ||
| close(promise.done) |
There was a problem hiding this comment.
@aknuds1 why is closing the channel here necessary?
There was a problem hiding this comment.
@charleskorn I guess it was old habit, thinking that the unused channel should be closed, but thinking it through again, it's actually not necessary. It should make no difference for garbage collection, AFAIK.
aknuds1
added a commit
that referenced
this pull request
Oct 23, 2023
…ache-context-cancellation Fix issue where `PostingsForMatchersCache` can cache a context cancellation error
3 tasks
aknuds1
added a commit
that referenced
this pull request
Oct 26, 2023
…ache-context-cancellation Fix issue where `PostingsForMatchersCache` can cache a context cancellation error
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initial request for a set of matchers to
PostingsForMatchersCache.PostingsForMatchers()cancels its context before the call returns, this cancellation can be cached, causing all subsequent calls to the cache for the same matchers to also return a context cancellation error while the cache entry is still live.While this PR is sufficient to fix the problem above, there are some further improvements we could consider in the future:
PostingsForMatchersCache.PostingsForMatchers()have cancelled their context, should we cancel the context passed to the underlyingPostingsForMatchersimplementation?