Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB.UnorderedChunkQuerier: Remove unused ctx argument #545

Merged
merged 1 commit into from
Oct 19, 2023
Merged

DB.UnorderedChunkQuerier: Remove unused ctx argument #545

merged 1 commit into from
Oct 19, 2023

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Oct 18, 2023 •
edited
Loading

Remove unused ctx argument from DB.UnorderedChunkQuerier. Also DB.ChunkQuerier doesn't have a ctx argument any longer.

Note that DB.UnorderedChunkQuerier doesn't exist upstream.

@aknuds1 aknuds1 added the chore label Oct 19, 2023
bboreham
bboreham approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you have a matching PR in Mimir ready?

@aknuds1
Copy link
Contributor Author

aknuds1 commented Oct 19, 2023

I guess you have a matching PR in Mimir ready?

Thanks @bboreham. I didn't make the PR yet, but made a local branch and the changes are minimal.

@aknuds1 aknuds1 merged commit 97933fb into main Oct 19, 2023
6 checks passed
@aknuds1 aknuds1 deleted the arve/unordered-chunks-context branch October 19, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknuds1 @bboreham