Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LabelQuerier.LabelValuesStream method #517

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jul 21, 2023

Add method storage.LabelQuerier.LabelValuesStream that returns an iterator over corresponding label values, instead of a slice.

Preliminary benchmark statistics, for respectively block and head index readers:

benchstat-block.txt
benchstat-head.txt

Depends on #576

Note to self
When the time comes to upstream, first post a proposal issue, to allow for discussion, before making a PR.

TODO:

@aknuds1 aknuds1 added the enhancement New feature or request label Jul 21, 2023
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 17 times, most recently from abe07c3 to d4a20e9 Compare September 5, 2023 08:23
@aknuds1 aknuds1 changed the title WIP: Add LabelQuerier.LabelValuesSet method WIP: Add LabelQuerier.LabelValuesStream method Sep 5, 2023
@aknuds1 aknuds1 changed the title WIP: Add LabelQuerier.LabelValuesStream method WIP: Add LabelQuerier.LabelValuesStream method Sep 5, 2023
@aknuds1 aknuds1 changed the title WIP: Add LabelQuerier.LabelValuesStream method Add LabelQuerier.LabelValuesStream method Sep 5, 2023
@aknuds1 aknuds1 changed the title Add LabelQuerier.LabelValuesStream method WIP: Add LabelQuerier.LabelValuesStream method Sep 6, 2023
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 5 times, most recently from 16292cf to 287e4a3 Compare September 11, 2023 15:31
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 8 times, most recently from 4902190 to f630927 Compare January 25, 2024 10:53
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 3 times, most recently from 74562a1 to 4a5d3ee Compare February 27, 2024 07:52
@aknuds1 aknuds1 force-pushed the arve/stream-labelvalues branch 2 times, most recently from 5043c92 to 2e1e45f Compare March 13, 2024 11:33
aknuds1 and others added 14 commits April 26, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants