Fix span name for HTTPClient calls #1244
Open
+57
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctc
requested review from
grcevski,
mariomac and
rafaelroquetto
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
==========================================
+ Coverage 78.35% 78.55% +0.20%
==========================================
Files 145 147 +2
Lines 14639 14743 +104
==========================================
+ Hits 11470 11581 +111
+ Misses 2570 2561 -9
- Partials 599 601 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
grcevski
approved these changes
Oct 10, 2024
grcevski
reviewed
Oct 15, 2024
test/integration/traces_test.go
Outdated
| @@ -752,7 +752,7 @@ func testNestedHTTPTracesKProbes(t *testing.T) { | |||
|
|
|||
| // Check the information of the java parent span | |||
| res = trace.FindByOperationName("GET /jtrace") | |||
| require.Len(t, res, 1) | |||
| require.Len(t, res, 2) | |||
There was a problem hiding this comment.
Ah right, I guess now multiple spans will match with the same URL path. I think we need to extend FindOperationByName to use an optional parameter which is the span kind and look for the server span. Otherwise many other tests will have an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are generating metrics like:
missing the route information in span name. This PR fixes this issue