Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Storybook Version Upgrade to Fix Custom Component Devmode #9893

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Nov 1, 2024

Description

Revert #9794. I tried just removing the svelte-preprocess override in the main package.json but the storybook build wouldn't succeed. So I reverted the entire commit. Locally, storybook passes so maybe that's ok?

Closes #9879

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 1, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/613b7b39f64de24ea6ce5377c1de13f9887541d3/gradio-5.4.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@613b7b39f64de24ea6ce5377c1de13f9887541d3#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/613b7b39f64de24ea6ce5377c1de13f9887541d3/gradio-client-1.7.1.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/613b7b39f64de24ea6ce5377c1de13f9887541d3/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 1, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/preview patch
@self/storybook patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Revert Storybook Version Upgrade to Fix Custom Component Devmode

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair
Copy link
Collaborator

hmm, seems storybook build is still failing

@pngwn
Copy link
Member

pngwn commented Nov 16, 2024

I'm really not sure what is going on here, the error doesn't make any sense. The file it is saying doesn't exist definitely exists, but I'm not sure why it can't resolve it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom components don't work
4 participants