Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add writer for Avro GenericRecord #2663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anthavio
Copy link
Contributor

@anthavio anthavio commented Sep 26, 2024

Add AvroStreamWriter to write Avro GenrericRecords

Pull request is WIP and following is TODO but I'd need bit of guidance how to tackle bits that require refactoring/integration with existing code

  • Conversions code of JsonToProtoMessage can be shared with AvroToProtoConverter
  • AvroStreamWriter is 99% same as JsonStreamWriter
  • Tests are missing

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2662☕️

If you write sample code, please follow the samples format.

@anthavio anthavio requested review from a team as code owners September 26, 2024 12:00
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants