Upgrade build to support shared multiplatform Kotlin libs #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gino-m
force-pushed
the
gino-m/2049/shared-libs
branch
from
bc8bc4c
to
0b66e9d
Compare
gino-m
changed the title
|
@shobhitagarwal1612 PTAL? |
gino-m
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2181 +/- ##
============================================
+ Coverage 52.72% 52.86% +0.13%
- Complexity 1204 1214 +10
============================================
Files 314 314
Lines 6101 6102 +1
Branches 636 635 -1
============================================
+ Hits 3217 3226 +9
+ Misses 2539 2532 -7
+ Partials 345 344 -1 ☔ View full report in Codecov by Sentry. |
Comment on lines
+59
to
+61
| sourceSets { | ||
| main.java.srcDirs += ['build/generated/source/kapt/devDebug'] | ||
| } |
There was a problem hiding this comment.
For context, we added the hilt generated classes for fixing our codecov plugin. In a separate PR, we can check whether it is fixed with updated version of Hilt or not. If yes, then we can get rid of this workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2049
Min required changes:
@Deprecatedon deprecated overrides@shobhitagarwal1612 @rfontanarosa @scolsen @justinkimtang FYI